Comments on: Symfony Form: unsetAllFieldsExcept() http://www.devexp.eu/2009/04/27/symfony-form-unsetallfieldsexcept/ DEVelopment EXPerience, shared with the world! Mon, 06 Sep 2010 10:41:43 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Van de Voorde Toni http://www.devexp.eu/2009/04/27/symfony-form-unsetallfieldsexcept/comment-page-1/#comment-219 Van de Voorde Toni Mon, 04 May 2009 07:41:36 +0000 http://www.devexp.eu/?p=706#comment-219 That's good news :) That’s good news :)

]]> By: David http://www.devexp.eu/2009/04/27/symfony-form-unsetallfieldsexcept/comment-page-1/#comment-218 David Mon, 04 May 2009 07:31:12 +0000 http://www.devexp.eu/?p=706#comment-218 Today I discovered that symfony 1.3 will include an sfForm::useFields() method that will do exactly what your unsetAllFieldsExcept() does: http://trac.symfony-project.org/changeset/17824 Today I discovered that symfony 1.3 will include an sfForm::useFields() method that will do exactly what your unsetAllFieldsExcept() does:
http://trac.symfony-project.org/changeset/17824

]]> By: Thomas R. http://www.devexp.eu/2009/04/27/symfony-form-unsetallfieldsexcept/comment-page-1/#comment-205 Thomas R. Wed, 29 Apr 2009 09:08:55 +0000 http://www.devexp.eu/?p=706#comment-205 This is more a security problem. If you add new fields in your model, then fields will appear on the form. Not always what we need. I have coded a similar function with a optional parameter to reorder field. http://trac.symfony-project.org/browser/plugins/swToolboxPlugin/sf1.2/trunk/lib/form/swToolboxFormHelper.class.php#L270 This is more a security problem. If you add new fields in your model, then fields will appear on the form. Not always what we need.

I have coded a similar function with a optional parameter to reorder field.

http://trac.symfony-project.org/browser/plugins/swToolboxPlugin/sf1.2/trunk/lib/form/swToolboxFormHelper.class.php#L270

]]> By: Van de Voorde Toni http://www.devexp.eu/2009/04/27/symfony-form-unsetallfieldsexcept/comment-page-1/#comment-204 Van de Voorde Toni Wed, 29 Apr 2009 07:26:51 +0000 http://www.devexp.eu/?p=706#comment-204 Correct for the performance issue. If in the form you create you need to unset/reinitialize at least one field then it's better to override the setup function and initialize it from the first time correctly. The problem is that those (important) things are not well documented in symfony (yet), and some developers do not take the time to 'investigate' what happens in the super classes. I saw a lot of form examples where the developers "re-set" there widgets/validators in the configure method instead of the setup function. The configure method, which is correctly named, is only to configure the existing widgets/validators (options etc). If I have the time I'll do some benchmarking on the 'unsetting' fields to see how much performance drop there is. Correct for the performance issue.

If in the form you create you need to unset/reinitialize at least one field then it’s better to override the setup function and initialize it from the first time correctly.

The problem is that those (important) things are not well documented in symfony (yet), and some developers do not take the time to ‘investigate’ what happens in the super classes.

I saw a lot of form examples where the developers “re-set” there widgets/validators in the configure method instead of the setup function. The configure method, which is correctly named, is only to configure the existing widgets/validators (options etc).

If I have the time I’ll do some benchmarking on the ‘unsetting’ fields to see how much performance drop there is.

]]> By: David http://www.devexp.eu/2009/04/27/symfony-form-unsetallfieldsexcept/comment-page-1/#comment-201 David Tue, 28 Apr 2009 18:59:39 +0000 http://www.devexp.eu/?p=706#comment-201 I'd go for the second one (unsetAllFieldsExcept()). I might even need this myself soon to clean up some of my forms ;-) What I don't like about this though is that it is very inefficient from a performance point of view. It just seems wrong to me to create a form with 20+ widgets and validators just to kill 19 of them immediately. Perhaps I should think about this a little more... I’d go for the second one (unsetAllFieldsExcept()). I might even need this myself soon to clean up some of my forms ;-)

What I don’t like about this though is that it is very inefficient from a performance point of view. It just seems wrong to me to create a form with 20+ widgets and validators just to kill 19 of them immediately. Perhaps I should think about this a little more…

]]>